Skip to content

feat: PollBuilder #10324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Feb 28, 2025
Merged

feat: PollBuilder #10324

merged 21 commits into from
Feb 28, 2025

Conversation

TAEMBO
Copy link
Contributor

@TAEMBO TAEMBO commented Jun 4, 2024

Please describe the changes this PR makes and why it should be merged:
Adds the PollBuilder class that creates API-compatible JSON data for sending polls.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@TAEMBO TAEMBO requested a review from a team as a code owner June 4, 2024 08:24
@vercel Vercel
Copy link

vercel bot commented Jun 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 9:13am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Feb 28, 2025 9:13am

@Jiralite Jiralite added this to the builders 1.9.0 milestone Jun 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.18421% with 21 lines in your changes missing coverage. Please review.

Project coverage is 39.12%. Comparing base (bb67671) to head (b28db3f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/builders/src/messages/poll/Poll.ts 85.71% 11 Missing ⚠️
packages/builders/src/messages/poll/PollAnswer.ts 74.07% 7 Missing ⚠️
...ages/builders/src/messages/poll/PollAnswerMedia.ts 81.25% 3 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10324      +/-   ##
==========================================
+ Coverage   38.66%   39.12%   +0.46%     
==========================================
  Files         238      244       +6     
  Lines       14644    14796     +152     
  Branches     1385     1412      +27     
==========================================
+ Hits         5662     5789     +127     
- Misses       8970     8995      +25     
  Partials       12       12
Flag Coverage Δ
builders 80.85% <86.18%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Jiralite
Jiralite reviewed Jun 4, 2024
View reviewed changes
@TAEMBO TAEMBO requested a review from Jiralite June 4, 2024 18:28
almeidx
almeidx reviewed Jun 5, 2024
View reviewed changes
@TAEMBO TAEMBO requested a review from almeidx June 5, 2024 17:18
Jiralite
Jiralite previously approved these changes Jun 6, 2024
View reviewed changes
@TAEMBO TAEMBO marked this pull request as draft June 20, 2024 08:28
@Jiralite Jiralite dismissed their stale review June 20, 2024 10:34

Stale.

@Jiralite Jiralite self-requested a review June 20, 2024 10:34
@TAEMBO TAEMBO marked this pull request as ready for review June 22, 2024 04:34
@TAEMBO TAEMBO requested a review from a team as a code owner June 22, 2024 04:34
@TAEMBO TAEMBO requested a review from SpaceEEC June 22, 2024 04:34
@TAEMBO
Copy link
Contributor Author

TAEMBO commented Jun 26, 2024

discord/discord-api-docs#6956

@Jiralite Jiralite removed this from the builders 1.9.0 milestone Jun 27, 2024
Jiralite

This comment was marked as resolved.

Sign in to view

@TAEMBO
Copy link
Contributor Author

TAEMBO commented Aug 20, 2024

@TAEMBO TAEMBO force-pushed the poll-builder branch 3 times, most recently from cac7a4d to 27a0cab Compare February 28, 2025 09:12
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js Feb 28, 2025
@kodiakhq kodiakhq bot merged commit 88bfeaa into discordjs:main Feb 28, 2025
24 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Feb 28, 2025
@TAEMBO TAEMBO deleted the poll-builder branch February 28, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@didinele didinele didinele approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/builders

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/builders

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@almeidx almeidx Awaiting requested review from almeidx

Assignees
No one assigned
Labels
packages:builders packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TAEMBO @almeidx @Jiralite @didinele @vladfrangu